Skip to content

zernike enable table is saved for each wft. Display diff - #369

Open
atsju wants to merge 2 commits into
masterfrom
JST/152-2
Open

zernike enable table is saved for each wft. Display diff#369
atsju wants to merge 2 commits into
masterfrom
JST/152-2

Conversation

@atsju

@atsju atsju commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

This one also improves #152 . We can probably do it differently and with better visuals but it's enough to validate the intent.
Just let me know.

you will notice small + and - before the zernike names.
It makes it much clearer witch zernike have been used to display a given waveform and what would change if hitting compute button.

@atsju
atsju requested review from githubdoe and gr5 August 11, 2026 06:00

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Used clang-tidy v20.1.2

Have any feedback or feature suggestions? Share it here.

Comment thread surfacemanager.cpp Outdated
@github-actions

Copy link
Copy Markdown

🚀 New build available for commit 96c8467
Download installer here

@github-actions

Copy link
Copy Markdown

🚀 New build available for commit b86941b
Download installer here

@gr5

gr5 commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

I love this feature! Chef's kiss.

It even keeps track if I select multiple wavefronts, change a zernike checkbox and hit recompute. It properly keeps track of which wavefronts were modified and which weren't.

There is a minor feature/bug however:

If I have 2 wavefronts, one was computed with spherical zernike checked and one without. I can click on the two wavefronts one at a time and I can see which one was calculated with and without. however if I select both wavefronts then it matters which I select last. Should there be a third symbol when it's mixed?

With software installers there are checkboxes that can be checked, unchecked, or there is a 3rd symbol to indicate that some of the sub features are checked and some are not. I don't want to change the checkboxes here but the "+" and "-" symbols perhaps to a third symbol "." or "*".

@gr5

gr5 commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Are you going to try to add a third symbol @atsju?

@atsju

atsju commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator Author

yes it sounds like an excellent idea.
I need some time.

more generally, I had in mind to fix lot of little identified issues but at low pace. Just let me know if you have release in mind.

@gr5

gr5 commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

I wanted to release this week but now Dale has a new feature and he hasn't done a PR and he may be adding more features so no rush at the moment.

@githubdoe

Copy link
Copy Markdown
Owner

I'm playing and do not have anything to release. When it is ready I want others to test it and decide if it is worth while and the GUI makes sense. So it is a long way away from being a released feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants